Add Cloglog Ordinal BART to Stochtree#196
Open
Entejar wants to merge 39 commits intoStochasticTree:mainfrom
Open
Add Cloglog Ordinal BART to Stochtree#196Entejar wants to merge 39 commits intoStochasticTree:mainfrom
Entejar wants to merge 39 commits intoStochasticTree:mainfrom
Conversation
Added functionality to adjust the model states before/after tree sampling for CLogLog Ordinal BART
Collaborator
|
Thanks for submitting a major increment for |
Collaborator
|
A few initial comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SuffStatandLeafModelclasses for Cloglog Ordinal BARTordinal_samplerand integrated into the sampling frameworkpartition_tracker(to support auxiliary data),tree_sampler.h, andsampler.cppcloglog_ordinal_bart()R interface functionWhy
Testing
cloglog_ordinal_bart()Notes
Thanks so much for reviewing this! Really appreciate your help and feedback as always :-)